#27: enum34 conditional requirement for poetry #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 20, 2019 07:37
|
@manrajgrover now that all checks/tests pass can we get this merged? |
manrajgrover
requested changes
Feb 18, 2020
requirements-dev.txt
Outdated
| @@ -1,3 +1,4 @@ | |||
| astroid==1.6.5 | |||
There was a problem hiding this comment.
I don't think we need this.
|
I think the build fails because of old setuptools version. Can you add an upgradation step in appveyor? |
manrajgrover
approved these changes
Feb 19, 2020
|
@tpinniger @DylanBartels This has been released in |
|
@tpinniger Thanks for working on this! :) |
|
My pleasure and Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of new feature, or changes
similar to the changes in py-log-symbols, fix the setup.py for poetry so enum34 isn't included
@manrajgrover