New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix get_given_constraint_keys for pydantic 2.1 #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for providing the PR to fix this bug!
We will need a test case to ensure the bug is fixed and won't occur again in the future. Since setting up tests with sphinx/pydantic is not trivial, feel free to allow me to contribute to your PR branch and I'm happy to add the test case.
Apart from that, I'm curious to know how you came up with this solution. Do you have some additional knowledge/docs about how __pydantic_core_schema__["definitions"]
behaves? Of course it would be best to open an issue in the pydantic project asking for clarification in the first place but maybe you have some insights here.
@mansenfranzen Sorry, I don't know more about
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 94.39% 94.68% +0.29%
==========================================
Files 12 12
Lines 1052 1035 -17
==========================================
- Hits 993 980 -13
+ Misses 59 55 -4
☔ View full report in Codecov by Sentry. |
workaround for #169