Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon does not work with ember-cli 3.0.0(-beta.2) #200

Closed
jacobq opened this issue Feb 6, 2018 · 4 comments
Closed

Addon does not work with ember-cli 3.0.0(-beta.2) #200

jacobq opened this issue Feb 6, 2018 · 4 comments

Comments

@jacobq
Copy link
Contributor

jacobq commented Feb 6, 2018

I have created a sample application here that demonstrates the problem. The error looks like this in this case:

Uncaught Error: Could not find module `ember-cli-notifications/styles/components/notification-container` imported from `ember-cli-notifications/components/notification-container`

It seems to be related to this line:

import styles from '../styles/components/notification-container';

If I comment that line out and replace it with const styles = {} or create the file ../styles/components/notification-container.js this error goes away.

@jacobq
Copy link
Contributor Author

jacobq commented Feb 6, 2018

This is an upstream problem and has now been fixed. We just need to upgrade to the new version in ember-cli-notification's package.json. (See salsify/ember-css-modules#95 ) I will create a PR for this shortly (if greenkeeper doesn't beat me to it).

@ahopkins
Copy link

Is t his working on Ember 3 yet? I was getting some errors when I tried upgrading. What version of this package do I need to be using?

@lamabiker
Copy link

@ahopkins not yet, but @jacobq 's PR should fix it #201

@mansona
Copy link
Owner

mansona commented Apr 19, 2018

This is now fixed in #197

Let me know if it is all working with your apps 👍

@mansona mansona closed this as completed Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants