Bump ember-css-modules & fix regression #201
Conversation
* Updates ember-css-modules to v0.7.7 See salsify/ember-css-modules#95 * Bump package version to 4.2.2
jacobq
changed the title
|
BTW, CI failure appears to be caused by romulomachado/ember-cli-string-helpers#19 |
jacobq
changed the title
Also updated `testem.js` to pass `--no-sandbox` option to support running inside of a container (e.g. travis when `sudo: false`) See ember-cli/ember-cli@24aeacc
|
@mansona Please let me know if you would like me to squash these commits or make any other changes. I'd love it if this could get merged and released soon. |
|
The ecsh node 4.x thing is fixed now so I will adjust this PR later today to unpin. |
* Ran `ember-cli-update --to 2.18` * Reverted `useYarn: true` change and unpinned ember-cli-string-helpers from v1.5.0 now that v1.7.0 fixed the node 4.x regression
|
🚀 |
|
Any news on this PR? Thanks guys |
|
Howdy folks 👋 Sorry for the delay but this has now been fixed in #197 I was hoping to get your PR merged @jacobq but the existing PR was staring the testing game for ember-cli-notifications and I didn't want to upgrade without making sure that we didn't break anything for all versions of Ember we support. I will be more active here now so I will be more responsive on PRs and issues, so don't give up if you want to contribute 😉 |
fix: Prevent error when environement settings aren't defined
getWithDefault(undefined, ...)(Closes Need to fix regression from #2f181d31 (breaks when environment variables not present) #202)ember-get-configin favor ofApplication.lookup('config:environment')(to make testable)See Handle beta CLI releases correctly salsify/ember-css-modules#95
ember-clifrom 2.16 to 2.18 viaember-cli-update(just for the heck of it)