Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prettier issues #315

Merged
merged 1 commit into from Aug 30, 2021
Merged

Fix prettier issues #315

merged 1 commit into from Aug 30, 2021

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Aug 29, 2021

/cc @mansona

computedPosition: computed('position', function () {
return `ember-cli-notifications-notification__container--${this.get(
'position'
)}`;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seriously prettier, how is this better 😭

Copy link
Owner

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a perfect PR 😍 lots of different changes but all a single logical change 💪

@mansona mansona merged commit 03c7bc2 into mansona:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants