Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pragma unroll syntax #2

Open
jeffhammond opened this issue Jun 11, 2017 · 0 comments
Open

pragma unroll syntax #2

jeffhammond opened this issue Jun 11, 2017 · 0 comments

Comments

@jeffhammond
Copy link
Contributor

jeffhammond commented Jun 11, 2017 •
edited
Loading

Intel and IBM compilers want parentheses around the unrolling factor, while OpenCL and NVIDIA do not. It's pretty easy to handle this along the lines of https://github.com/jeffhammond/nwchem-tce-triples-kernels/blob/master/src/pragma_vendor.h. If you want a pull request, I'll try to work on it.

neighbor.cpp(361): warning #125: expected a "("
            #pragma unroll 8

neighbor.cpp(278): warning #125: expected a "("
      #pragma unroll 4

References
jasonsewall-intel pushed a commit to jasonsewall-intel/miniMD that referenced this issue Feb 19, 2019
@Pennycook
Fix private variables in Atom::pack/unpack
2ca7fa2 
j should be private, not shared.
Missed in Mantevo#2.
jasonsewall-intel pushed a commit to jasonsewall-intel/miniMD that referenced this issue Feb 19, 2019
@Pennycook
Fix private variables in Thermo::temperature
2cff56e 
vx, vy, vz should be private, not shared.
Missed in Mantevo#2.
jasonsewall-intel pushed a commit to jasonsewall-intel/miniMD that referenced this issue Feb 19, 2019
@Pennycook
Fix private variables in Comm::exchange
0fea084 
value should be private, not shared.
Missed in Mantevo#2.
jasonsewall-intel pushed a commit to jasonsewall-intel/miniMD that referenced this issue Feb 19, 2019
@Pennycook
Fix private variables in Atom::pack/unpack
70be73d 
j should be private, not shared.
Missed in Mantevo#2.
jasonsewall-intel pushed a commit to jasonsewall-intel/miniMD that referenced this issue Feb 19, 2019
@Pennycook
Fix private variables in Thermo::temperature
a1df9b6 
vx, vy, vz should be private, not shared.
Missed in Mantevo#2.
jasonsewall-intel pushed a commit to jasonsewall-intel/miniMD that referenced this issue Feb 19, 2019
@Pennycook
Fix private variables in Comm::exchange
2357ab8 
value should be private, not shared.
Missed in Mantevo#2.
nmm0 added a commit to nmm0/miniMD that referenced this issue Dec 17, 2020
@nmm0
Merge branch '2-resilience-api-update' into 'master'
e9a3c40 
Resolve "resilience api update"

Closes Mantevo#2

See merge request kokkos-resilience/minimd!2
nmm0 pushed a commit to nmm0/miniMD that referenced this issue Dec 17, 2020
@Pennycook @nmm0
Fix private variables in Atom::pack/unpack
23c2295 
j should be private, not shared.
Missed in Mantevo#2.
nmm0 pushed a commit to nmm0/miniMD that referenced this issue Dec 17, 2020
@Pennycook @nmm0
Fix private variables in Thermo::temperature
38d37d4 
vx, vy, vz should be private, not shared.
Missed in Mantevo#2.
nmm0 pushed a commit to nmm0/miniMD that referenced this issue Dec 17, 2020
@Pennycook @nmm0
Fix private variables in Comm::exchange
617b7c9 
value should be private, not shared.
Missed in Mantevo#2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffhammond