Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skill helpers #21

Merged
merged 9 commits into from
Nov 2, 2016
Merged

Skill helpers #21

merged 9 commits into from
Nov 2, 2016

Conversation

manthanhd
Copy link
Owner

Adds StaticResponseSkill and StaticRandomResponseSkill classes to help simplify skill-making.

@manthanhd
Removed global install of istanbul
94bbb2d 
Istanbul is now referenced from the installed node_modules folder.
Since it is already part of the dev dependencies, the global install is not needed.
@manthanhd
Added StaticResponseSkill helper class
0805a0d
@manthanhd
Added StaticRandomResponseSkill + more coverage
b003577
@manthanhd
Removed sinonjs.
01dc7bf
@coveralls
Copy link

coveralls commented Oct 30, 2016 •
edited

Coverage Status

Coverage increased (+0.1%) to 99.138% when pulling 01dc7bf on skill_helpers into b82c91c on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.138% when pulling 01dc7bf on skill_helpers into b82c91c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.138% when pulling 01dc7bf on skill_helpers into b82c91c on master.

@manthanhd
Copy link
Owner Author

Closes issue #19 and #20

@coveralls
Copy link

coveralls commented Oct 31, 2016 •
edited

Coverage Status

Coverage decreased (-0.3%) to 98.734% when pulling 904a5c6 on skill_helpers into b82c91c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.734% when pulling 904a5c6 on skill_helpers into b82c91c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 99.174% when pulling 59f65ce on skill_helpers into ecfb97d on master.

@manthanhd manthanhd merged commit 2b350f2 into master Nov 2, 2016
@manthanhd manthanhd deleted the skill_helpers branch November 2, 2016 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manthanhd @coveralls