Follow up #26
Merged
Follow up #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skills can now gain exclusive lock to the conversation for a single followUp. They should be able to lock again if they need more information from the user. The lock only lasts for a single next conversation.
Context now is made up of two levels:
Context:
\---lock: 'skill_name'
\---data
\---...
\---...
The data part is sent to the skill. Since this is a lower level object, the skill has
no way to access the above layer. This change in structure is useful to store
private metadata that the bot doesn't want the skill to be able to access.
|
Closed pull on talkify-natural-classifier to fix issue where the built-in classifier would throw exceptions. |
This version does not throw synchronous exceptions in the getClassifications method.
… to 2.0.0 This is a breaking change since the final() method now no longer calls the next() method.
This is to supress build time errors with various npm modules.
The usage didn't feel very elegant. Chaining final reads nicer than passing in a random looking second parameter. Updated documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows locking of conversation by a skill for a follow-up.
Closes #8