Feat/queues #224
Feat/queues #224
Conversation
# Conflicts: # composer.lock
…er loop and refactor the logic with
# Conflicts: # composer.lock
# Conflicts: # composer.lock # src/init.php
There was a problem hiding this comment.
-
Do we really need the #[Override] annotation? We haven't used attributes so far, and I think it's a good idea not to use them until we really need them.
-
The doc blocks (documentation comments) are missing in the functions. Please consider adding them. It would also be great to include some explanatory text because when we revisit the code later, we might forget what each part is for and why it exists. So, adding information about critical sections is crucial.
-
We should avoid having multiple blank lines after an opening curly brace { and before a closing curly brace } because it's unnecessary. Also, avoid using more than one blank line to separate code blocks, as it's useless.
| /** @var Model<T>|null $model */ | ||
| return $model; | ||
| } | ||
|
|
There was a problem hiding this comment.
Try to avoid 2++ blank lines, one is enough
There was a problem hiding this comment.
Add this to codestyle as discussed, to make this fixes automatically, if you really think that's important or somehow can help
No description provided.