Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/create table like #manticoresoftware/manticoresearch/issues/1788 #257

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

djklim87
Copy link
Contributor

No description provided.

Copy link
Contributor

@donhardman donhardman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just little fixes with blank lines and we can merge

src/Plugin/Create/Handler.php Outdated Show resolved Hide resolved
src/Plugin/Create/Handler.php Show resolved Hide resolved
src/Plugin/Create/Handler.php Show resolved Hide resolved
Copy link
Contributor

@donhardman donhardman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make hasMatch simple and fast without parsing include

src/Plugin/Create/Payload.php Show resolved Hide resolved
@djklim87 djklim87 merged commit 0796823 into main Apr 26, 2024
3 checks passed
@djklim87 djklim87 deleted the feat/create_table_like branch April 26, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants