Feat/rename table #260
Merged
Feat/rename table #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2024 17:42
# Conflicts: # composer.lock # src/init.php
donhardman
requested changes
Apr 26, 2024
src/Plugin/RenameTable/Payload.php
Outdated
| * } | ||
| * } $payload | ||
| */ | ||
| $payload = Payload::$sqlQueryParser::parse($request->payload); |
There was a problem hiding this comment.
hasMatch should be as lightweight as possible. We should use simple validation here with something like strpos, and avoid doing any heavy query parsing because it's blocking and slowing down other plugins.
As discussed at last dev call we decide to separate plugins to keep it simple and clear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.