Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on large number at the histogram #1690

Closed
tomatolog opened this issue Dec 20, 2023 · 1 comment
Closed

crash on large number at the histogram #1690

tomatolog opened this issue Dec 20, 2023 · 1 comment
Assignees

Comments

@tomatolog
Copy link
Contributor

daemon with the version 6.2.13 a28f6e087@231219 dev (columnar 2.2.5 c323cec@231127) (secondary 2.2.5 c323cec@231127)
after create table, populate table and flush data into disk chunk q.txt the following query

select id from t where id=7064099163037773392

cause crash on spawning iterators with the following stack

>	HistogramStreamed_T<__int64>::LerpCounter Line 500	C++
 	HistogramStreamed_T<__int64>::GetBucket Line 522	C++
 	HistogramStreamed_T<__int64>::EstimateValues Line 605	C++
 	HistogramStreamed_T<__int64>::EstimateRsetSize Line 554	C++
 	FetchHistogramInfo Line 669	C++
 	SelectIterators Line 1011	C++
 	CSphIndex_VLN::ChooseIterators Line 8152	C++
 	CSphIndex_VLN::SpawnIterators Line 8184	C++
 	CSphIndex_VLN::MultiScan Line 8403	C++
 	CSphIndex_VLN::MultiQuery Line 11162	C++

seems the large numbers cause the double overflow

  | tBucketL.m_tCentroid | 7064099163037773392 | const __int64
  | tBucketR.m_tCentroid | 7064099163037773393 | const __int64
  | fDist | 0.0000000000000000 | double
  | fDistL | 0.0000000000000000 | double
  | fLerp | -nan(ind) | double
@tomatolog
Copy link
Contributor Author

The crash should be fixed at 5e4dae2

@sanikolaev sanikolaev added the rel::upcoming Upcoming release label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants