Fix and re-enable CI tests #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the slack hook to an empty string is the easiest way to disable to hook for testing.
The old script stomped on .env files and did no cleanup. The new script uses and existing .env/DB if it exists and generates one a .env file if not. If a .env file and DB did not exist then they are cleaned at the end. Services are also only booted if they are not already running.
Arguments are passed directly to python manage.py test command
martyngigg
force-pushed
the
fixing-ci-tests
branch
from
80a4562
to
079aeb4
Compare
don't have wait
Set a default DEBUG value to avoid compose warning
A volume is used for this now.
The postgres container chowns the bind mounted directory and this can then require sudo to remove on the host. Users will need to remove pgdata by hand if they want to.
martyngigg
force-pushed
the
fixing-ci-tests
branch
from
fa2805d
to
973d3bb
Compare
This works in the case that we don't own the DB directory.
jhaigh0
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few years ago we renamed all of the default branches to
main. This basically deactivated the CI tests as they hadmasterexplicitly stated as a target branch.This PR fixes the workflow and overhauls the testing script to make it more flexible to use locally. The script now also accepts arguments to run a subset of the tests.
Testing
.envfile andpgdatadirectory runbash run_web_tests.shto use the existing environment.envto.env.backupand runbash run_web_tests.sh. It should fail saying you have apgdatadirectory.pgdatatopgdata.backupand rerun the script. It will create a .env file for the tests and remove both this and the generatedpgdatadirectory at the end. You can restore your files by renaming them back.bash run_web_tests services/to limit the tests that will run.