Skip to content

Commit

Permalink
Fixes for OSX 10.8 & Intel compiler.
Browse files Browse the repository at this point in the history
It doesn't generate a symbol for the destructor of the *FileLoader
interfaces unless explicitly defined. All other platforms, including
OS X 10.6, don't show this problem.
Refs #7263
  • Loading branch information
martyngigg committed Jul 5, 2013
1 parent 39bfe42 commit 04e1697
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Code/Mantid/Framework/API/inc/MantidAPI/IFileLoader.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ namespace Mantid
class MANTID_API_DLL IFileLoader : public Algorithm
{
public:
/// Virtual destructor (required by linker on some versions of OS X/Intel compiler)
virtual ~IFileLoader() {}
/// Returns a confidence value that this algorithm can load a file
virtual int confidence(Kernel::FileDescriptor & descriptor) const = 0;
};
Expand Down
2 changes: 2 additions & 0 deletions Code/Mantid/Framework/API/inc/MantidAPI/IHDFFileLoader.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ namespace Mantid
class DLLExport IHDFFileLoader : public API::Algorithm
{
public:
/// Virtual destructor (required by linker on some versions of OS X/Intel compiler)
virtual ~IHDFFileLoader() {}
/// Returns a confidence value that this algorithm can load a file
virtual int confidence(Kernel::HDFDescriptor & descriptor) const = 0;
};
Expand Down

1 comment on commit 04e1697

@martyngigg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I was wrong about it working on 10.6. It must just be an intel compiler issue.

Please sign in to comment.