dynamic_cast, setCurrentFont(), coverity issue 1075815, re #11152

mantidproject · Feb 22, 2015 · 12a4cfa · 12a4cfa
1 parent b97348c
commit 12a4cfa
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Code/Mantid/MantidPlot/src/Graph.cpp b/Code/Mantid/MantidPlot/src/Graph.cpp
@@ -5167,8 +5167,10 @@ void Graph::setCurrentFont(const QFont& f)
     QList<QwtPlotItem *> curves = d_plot->curvesList();
     foreach(QwtPlotItem *i, curves){
       DataCurve* dc = dynamic_cast<DataCurve *>(i);
-      if(dc && i->rtti() != QwtPlotItem::Rtti_PlotSpectrogram &&
-          dynamic_cast<PlotCurve*>(i)->type() != Graph::Function){
+      PlotCurve* pc = dynamic_cast<PlotCurve*>(i);
+      if(pc && dc
+         && i->rtti() != QwtPlotItem::Rtti_PlotSpectrogram &&
+         pc->type() != Graph::Function){
         if(dc->hasSelectedLabels()){
           dc->setLabelsFont(f);
           d_plot->replot();