Refs #3868. Fixing cppcheck warnings.

mantidproject · Jan 5, 2012 · 25b630c · 25b630c
1 parent f4d6e19
commit 25b630c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/...es/ParaviewPlugins/ParaViewFilters/MDEWRebinningCutterOperator/vtkMDEWRebinningCutter.cxx b/...es/ParaviewPlugins/ParaViewFilters/MDEWRebinningCutterOperator/vtkMDEWRebinningCutter.cxx
@@ -382,11 +382,10 @@ double vtkMDEWRebinningCutter::GetInputMaxThreshold()
 unsigned long vtkMDEWRebinningCutter::GetMTime()
 {
   unsigned long mTime = this->Superclass::GetMTime();
-  unsigned long time;
 
   if (this->m_clipFunction != NULL)
   {
-
+    unsigned long time;
     time = this->m_clipFunction->GetMTime();
     if(time > mTime)
     {

diff --git a/...aviewPlugins/ParaViewFilters/RebinningTransformOperator/vtkRebinningTransformOperator.cxx b/...aviewPlugins/ParaViewFilters/RebinningTransformOperator/vtkRebinningTransformOperator.cxx
@@ -302,7 +302,6 @@ int vtkRebinningTransformOperator::RequestInformation(vtkInformation* vtkNotUsed
     }
     catch(std::exception& e)
     {
-      std::string ex = e.what();
     }
   }
   setTimeRange(outputVector);

diff --git a/Code/Mantid/Vates/VatesAPI/src/MDEWRebinningPresenter.cpp b/Code/Mantid/Vates/VatesAPI/src/MDEWRebinningPresenter.cpp
@@ -264,8 +264,7 @@ namespace Mantid
         Mantid::MDEvents::BinMD hist_alg;
         hist_alg.initialize();
 
-        hist_alg.setPropertyValue("InputWorkspace", wsName);
-        std::string id; 
+        hist_alg.setPropertyValue("InputWorkspace", wsName); 
 
         if(m_view->getApplyClip())
         {

diff --git a/Code/Mantid/Vates/VatesAPI/src/SynchronisingGeometryPresenter.cpp b/Code/Mantid/Vates/VatesAPI/src/SynchronisingGeometryPresenter.cpp
@@ -27,7 +27,7 @@ namespace Mantid
     struct FindId : public std::unary_function <DimPresenter_sptr, bool>
     {
       const std::string m_id;
-      FindId(const std::string id) : m_id(id){ }
+      FindId(const std::string &id) : m_id(id){ }
 
       bool operator ()(const DimPresenter_sptr obj) const
       {
@@ -40,7 +40,7 @@ namespace Mantid
     struct FindModelId : public std::unary_function <IMDDimension_sptr, bool>
     {
       const std::string m_id;
-      FindModelId(const std::string id) : m_id(id){ }
+      FindModelId(const std::string &id) : m_id(id){ }
 
       bool operator ()(const IMDDimension_sptr obj) const
       {