check dynamic_cast, coverity issue 1075737, re #11151,

mantidproject · Feb 21, 2015 · 37cc588 · 37cc588
1 parent b4c62ec
commit 37cc588
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/Code/Mantid/MantidPlot/src/PlotDialog.cpp b/Code/Mantid/MantidPlot/src/PlotDialog.cpp
@@ -3110,6 +3110,16 @@ CurveTreeItem::CurveTreeItem(QwtPlotItem *curve, LayerItem *parent, const QStrin
   setIcon(0, getQPixmap("graph_disabled_xpm"));
 }
 
+Graph* CurveTreeItem::graph()
+{
+  LayerItem *l = dynamic_cast<LayerItem *>(parent());
+  if (l) {
+    return l->graph();
+  } else {
+    return NULL;
+  }
+}
+
 void CurveTreeItem::setActive(bool on)
 {
   if (on)

diff --git a/Code/Mantid/MantidPlot/src/PlotDialog.h b/Code/Mantid/MantidPlot/src/PlotDialog.h
@@ -298,7 +298,7 @@ class CurveTreeItem : public QTreeWidgetItem
   enum {PlotCurveTreeItem = 1002};
   CurveTreeItem(QwtPlotItem *curve, LayerItem *parent, const QString& s);
 
-  Graph* graph(){return dynamic_cast<LayerItem *>(parent())->graph();};
+  Graph* graph();
   void setActive(bool on);
 
   QwtPlotItem *plotItem() const{ return d_curve; };