Clear more MSVC compiler warnings. Re #4473.

Code/Mantid/Framework/Algorithms/src/ApplyDeadTimeCorr.cpp

@@ -104,7 +104,7 @@ void ApplyDeadTimeCorr::exec()
 
                     setProperty("OutputWorkspace", outputWs);
                 }
-                catch(std::runtime_error& ex)
+                catch(std::runtime_error&)
                 {
                     throw std::invalid_argument("Invalid argument for algorithm.");
                 }

Code/Mantid/Framework/Algorithms/src/FilterEventsHighFrequency.cpp

@@ -346,7 +346,7 @@ namespace Algorithms
 
       ifs.close();
 
-    } catch (std::ifstream::failure & e){
+    } catch (std::ifstream::failure&){
       // b. Using faking offset/calibration
       g_log.error() << "Open calibration/offset file " << calfilename << " error " << std::endl;
       g_log.notice() << "Using default detector offset/calibration" << std::endl;

Code/Mantid/Framework/Algorithms/src/MedianDetectorTest.cpp

@@ -182,7 +182,7 @@ namespace Mantid
         }
       }
       //catch all exceptions because the solid angle calculation is optional
-      catch(std::exception & e)
+      catch(std::exception&)
       {
         g_log.warning(
             "Precision warning:  Can't find detector geometry " + name() +

Code/Mantid/Framework/Algorithms/src/StripVanadiumPeaks2.cpp

@@ -53,7 +53,7 @@ DECLARE_ALGORITHM(StripVanadiumPeaks2)
       "If the input workspace is an EventWorkspace, then the output must be different (and will be made into a Workspace2D)." );
 
     BoundedValidator<int> *min = new BoundedValidator<int>();
-    min->setLower(1.0);
+    min->setLower(1);
     // The estimated width of a peak in terms of number of channels
     declareProperty("FWHM", 7, min,
       "The number of points covered, on average, by the fwhm of a peak. Passed through to FindPeaks. Default 7." );

Code/Mantid/Framework/Algorithms/src/TOFSANSResolution.cpp

@@ -189,9 +189,9 @@ void TOFSANSResolution::exec()
 
       const double dwl_over_wl = 3.9560*getTOFResolution(itev->m_tof)/(1000.0*(L1+L2)*itev->m_tof);
       const double dq_over_q = std::sqrt(dTheta2/(theta*theta)+dwl_over_wl*dwl_over_wl);
-
+      
       PARALLEL_CRITICAL(iq)    /* Write to shared memory - must protect */
-      if (iq>=0 && iq < xLength-1 && !dq_over_q!=dq_over_q && dq_over_q>0)
+      if (iq>=0 && iq < xLength-1 && !boost::math::isnan(dq_over_q) && dq_over_q>0)
       {
         DxOut[iq] += q*dq_over_q*itev->m_weight;
         XNorm[iq] += itev->m_weight;

Code/Mantid/Framework/Algorithms/src/XDataConverter.cpp

@@ -55,7 +55,7 @@ namespace Mantid
 
       const int numSpectra = static_cast<int>(inputWS->getNumberHistograms());
       const size_t numYValues = inputWS->blocksize();
-      const int numXValues = getNewXSize(inputWS);
+      const size_t numXValues = getNewXSize(inputWS);
       m_sharedX = API::WorkspaceHelpers::sharedXData(inputWS);
       // Create the new workspace 
       MatrixWorkspace_sptr outputWS = WorkspaceFactory::Instance().create(inputWS, numSpectra, numXValues, numYValues);

Code/Mantid/Framework/Algorithms/test/CropWorkspaceTest.h

@@ -107,7 +107,7 @@ class CropWorkspaceTest : public CxxTest::TestSuite
     EventWorkspace_sptr test_in = WorkspaceCreationHelper::CreateEventWorkspace(36, 50, 50, 0.0, 2., 2);
     //Fake a d-spacing unit in the data.
     test_in->getAxis(0)->unit() =UnitFactory::Instance().create("TOF");
-    test_in->setInstrument( ComponentCreationHelper::createTestInstrumentCylindrical(4.0, false) );
+    test_in->setInstrument( ComponentCreationHelper::createTestInstrumentCylindrical(4, false) );
     //Add it to the workspace
     AnalysisDataService::Instance().add(wsName, test_in);
   }

Code/Mantid/Framework/Crystal/inc/MantidCrystal/AnvredCorrection.h

@@ -25,7 +25,7 @@ namespace Crystal
 
   const double STEPS_PER_ANGSTROM = 100;  // resolution of lamda table 
 
-  const int NUM_WAVELENGTHS = std::ceil( MAX_WAVELENGTH * STEPS_PER_ANGSTROM);
+  const int NUM_WAVELENGTHS = static_cast<int>(std::ceil( MAX_WAVELENGTH * STEPS_PER_ANGSTROM));
 
   const double radtodeg_half = 180.0/M_PI/2.;
   /** Calculates anvred correction factors for attenuation due to absorption and scattering in a spherical sample.

Code/Mantid/Framework/Crystal/inc/MantidCrystal/SaveHKL.h

@@ -28,7 +28,7 @@ namespace Crystal
 
   const double STEPS_PER_ANGSTROM = 100;  // resolution of lamda table
 
-  const int NUM_WAVELENGTHS = std::ceil( MAX_WAVELENGTH * STEPS_PER_ANGSTROM);
+  const int NUM_WAVELENGTHS = static_cast<int>(std::ceil( MAX_WAVELENGTH * STEPS_PER_ANGSTROM));
 
   const double radtodeg_half = 180.0/M_PI/2.;
 

Code/Mantid/Framework/Crystal/inc/MantidCrystal/TOFExtinction.h

@@ -28,7 +28,7 @@ namespace Crystal
 
   const double STEPS_PER_ANGSTROM = 100;  // resolution of lamda table
 
-  const int NUM_WAVELENGTHS = std::ceil( MAX_WAVELENGTH * STEPS_PER_ANGSTROM);
+  const int NUM_WAVELENGTHS = static_cast<int>(std::ceil( MAX_WAVELENGTH * STEPS_PER_ANGSTROM));
 
   const double radtodeg_half = 180.0/M_PI/2.;
 

Code/Mantid/Framework/Crystal/src/PeakIntegration.cpp

@@ -756,7 +756,7 @@ void PeakIntegration::cluster(double **matrix, int m, int n, int **mask)
   {
     for (int j=0; j<n; j++)
     {
-      mask[i][j] = 0.0;
+      mask[i][j] = 0;
       if(matrix[i][j] > max)
       {
         max = matrix[i][j];

Code/Mantid/Framework/Crystal/src/SaveHKL.cpp

@@ -110,7 +110,7 @@ namespace Crystal
     if (append)
     {
       out.open( filename.c_str(), std::ios::in|std::ios::out|std::ios::ate);
-      long pos = out.tellp();
+      std::streamoff pos = out.tellp();
       out.seekp (28);
       out >> firstrun;
       out.seekp (pos - 110);

Code/Mantid/Framework/DataHandling/src/LoadDetectorsGroupingFile.cpp

@@ -554,7 +554,7 @@ namespace DataHandling
     std::string value = "";
 
     // 2. Loop to find
-    for (size_t i = 0; i < att->length(); i ++){
+    for (unsigned long i = 0; i < att->length(); ++i){
       Poco::XML::Node* cNode = att->item(i);
       if (cNode->localName().compare(attributename) == 0){
         value = cNode->getNodeValue();

Code/Mantid/Framework/DataHandling/src/LoadEventNexus.cpp

@@ -400,7 +400,7 @@ class LoadBankFromDiskTask : public Task
       // First, get info about the event_time_zero field in this bank
       file.openData("event_time_zero");
     }
-    catch (::NeXus::Exception & e)
+    catch (::NeXus::Exception&)
     {
       // Field not found error is most likely.
       // Use the "proton_charge" das logs.

Code/Mantid/Framework/DataHandling/src/LoadNexusLogs.cpp

@@ -233,7 +233,7 @@ namespace Mantid
       {
         file.openGroup("Veto_pulse", "NXgroup");
       }
-      catch (::NeXus::Exception & e)
+      catch (::NeXus::Exception&)
       {
         // No group. This is common in older files
         return;

Code/Mantid/Framework/DataObjects/src/EventList.cpp

@@ -583,7 +583,7 @@ namespace DataObjects
     case WEIGHTED:
       return weightedEvents[event_number];
     case WEIGHTED_NOTIME:
-      return WeightedEvent(weightedEventsNoTime[event_number].tof(), 0., weightedEventsNoTime[event_number].weight(), weightedEventsNoTime[event_number].errorSquared());
+      return WeightedEvent(weightedEventsNoTime[event_number].tof(), 0, weightedEventsNoTime[event_number].weight(), weightedEventsNoTime[event_number].errorSquared());
     }
     throw std::runtime_error("EventList: invalid event type value was found.");
   }

Code/Mantid/Framework/ICat/test/ICatTestHelper.cpp

@@ -1,5 +1,4 @@
 #include "ICatTestHelper.h"
-#include "MantidICat/ICatExport.h"
 
 namespace ICatTestHelper
 {

Code/Mantid/Framework/ICat/test/ICatTestHelper.h

@@ -4,12 +4,11 @@
 #include "MantidICat/CatalogLogin.h"
 #include "MantidICat/Session.h"
 #include "MantidKernel/ConfigService.h"
-#include "MantidICat/ICatExport.h"
 
 namespace ICatTestHelper
 {
   /// Skip all unit tests if ICat server is down
-  EXPORT_OPT_MANTID_ICAT bool skipTests();
+  bool skipTests();
 }
 
 #endif

Code/Mantid/Framework/MDAlgorithms/src/CompareMDWorkspaces.cpp

@@ -265,7 +265,7 @@ namespace MDAlgorithms
               }
             }
           }
-          catch (CompareFailsException & e)
+          catch (CompareFailsException&)
           {
             // Boxes must release events if the check fails
             mdbox1->releaseEvents();

Code/Mantid/Framework/MDEvents/src/BoxControllerSettingsAlgorithm.cpp

@@ -37,7 +37,7 @@ namespace MDEvents
   void BoxControllerSettingsAlgorithm::initBoxControllerProps(const std::string & SplitInto, int SplitThreshold, int MaxRecursionDepth)
   {
     BoundedValidator<int> *mustBePositive = new BoundedValidator<int> ();
-    mustBePositive->setLower(0.0);
+    mustBePositive->setLower(0);
     BoundedValidator<int> *mustBeMoreThen1 = new BoundedValidator<int> ();
     mustBeMoreThen1->setLower(1);
 

Code/Mantid/Framework/MDEvents/src/SliceMD.cpp

@@ -115,7 +115,7 @@ namespace MDEvents
     declareProperty("TakeMaxRecursionDepthFromInput", true, "Copy the maximum recursion depth from the input workspace.");
 
     BoundedValidator<int> *mustBePositiveInteger = new BoundedValidator<int>();
-    mustBePositiveInteger->setLower(0.0);
+    mustBePositiveInteger->setLower(0);
 
     declareProperty("MaxRecursionDepth", 1000, mustBePositiveInteger,
     "Sets the maximum recursion depth to use. Can be used to constrain the workspaces internal structure");

Code/Mantid/Framework/MDEvents/test/MDBoxTest.h

@@ -181,7 +181,7 @@ class MDBoxTest :    public CxxTest::TestSuite
     ev.setCenter(0, 2.0);
     ev.setCenter(1, 3.0);
 
-    int num = 5e5;
+    int num = 500000;
     PARALLEL_FOR_NO_WSP_CHECK()
     for (int i=0; i < num; i++)
     {

Code/Mantid/Framework/MDEvents/test/MDGridBoxTest.h

@@ -1373,7 +1373,7 @@ class MDGridBoxTestPerformance : public CxxTest::TestSuite
     box3b = MDEventsTestHelper::makeRecursiveMDGridBox<3>(5,1);
 
     // Make the list of fake events, random dist.
-    size_t num = 1e6;
+    size_t num = 1000000;
     events.clear();
 
     boost::mt19937 rng;