fix uninit coverity issues in ADARA, 1075353-1075356, re #11829

mantidproject · May 26, 2015 · 6efe910 · 6efe910
1 parent be7d5ee
commit 6efe910
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/Code/Mantid/Framework/LiveData/src/ADARA/ADARAPackets.cpp b/Code/Mantid/Framework/LiveData/src/ADARA/ADARAPackets.cpp
@@ -109,16 +109,25 @@ SourceListPkt::SourceListPkt(const SourceListPkt &pkt) : Packet(pkt) {}
 /* ------------------------------------------------------------------------ */
 
 BankedEventPkt::BankedEventPkt(const uint8_t *data, uint32_t len)
-    : Packet(data, len), m_fields((const uint32_t *)payload()) {
+  : Packet(data, len), m_fields((const uint32_t *)payload()), m_curEvent(NULL),
+    m_lastFieldIndex(0), m_curFieldIndex(0), m_sourceStartIndex(0), m_bankCount(0),
+    m_TOFOffset(0), m_isCorrected(false), m_bankNum(0), m_bankStartIndex(0),
+    m_bankId(0), m_eventCount(0)
+{
   if (m_payload_len < (4 * sizeof(uint32_t)))
     throw invalid_packet("BankedEvent packet is too short");
 
   m_lastFieldIndex = (payload_length() / 4) - 1;
 }
 
 BankedEventPkt::BankedEventPkt(const BankedEventPkt &pkt)
-    : Packet(pkt), m_fields((const uint32_t *)payload()),
-      m_lastFieldIndex((payload_length() / 4) - 1) {}
+    : Packet(pkt), m_fields((const uint32_t *)payload()), m_curEvent(NULL),
+      m_lastFieldIndex(0), m_curFieldIndex(0), m_sourceStartIndex(0),
+      m_bankCount(0), m_TOFOffset(0), m_isCorrected(false), m_bankNum(0),
+      m_bankStartIndex(0), m_bankId(0), m_eventCount(0)
+{
+  m_lastFieldIndex = ((payload_length() / 4) - 1);
+}
 
 // The fact that events are wrapped up in banks which are wrapped up in source
 // sections is abstracted away (with the exception of checking the COR flag and
@@ -361,7 +370,7 @@ TransCompletePkt::TransCompletePkt(const uint8_t *data, uint32_t len)
 }
 
 TransCompletePkt::TransCompletePkt(const TransCompletePkt &pkt)
-    : Packet(pkt), m_reason(pkt.m_reason) {}
+    : Packet(pkt), m_status(VariableStatus::NOT_REPORTED), m_reason(pkt.m_reason) {}
 
 /* ------------------------------------------------------------------------ */
 

diff --git a/Code/Mantid/Framework/LiveData/src/ADARA/ADARAParser.cpp b/Code/Mantid/Framework/LiveData/src/ADARA/ADARAParser.cpp
@@ -8,7 +8,7 @@ using namespace ADARA;
 
 Parser::Parser(unsigned int initial_buffer_size, unsigned int max_pkt_size)
     : m_size(initial_buffer_size), m_max_size(max_pkt_size), m_len(0),
-      m_restart_offset(0), m_oversize_len(0) {
+      m_restart_offset(0), m_oversize_len(0), m_oversize_offset(0) {
   m_buffer = new uint8_t[initial_buffer_size];
 }