Refs #11094 Resolve Coverity issues in updateTableNames

mantidproject · Feb 16, 2015 · 8eea26c · 8eea26c
1 parent 0a6fc57
commit 8eea26c
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/Code/Mantid/MantidPlot/src/ApplicationWindow.cpp b/Code/Mantid/MantidPlot/src/ApplicationWindow.cpp
@@ -2203,15 +2203,17 @@ void ApplicationWindow::updateTableNames(const QString& oldName, const QString&
 {
   QList<MdiSubWindow *> windows = windowsList();
   foreach (MdiSubWindow *w, windows) {
-    if (w->isA("MultiLayer")) {
-      QList<Graph *> layers = dynamic_cast<MultiLayer*>(w)->layersList();
+    auto ml = dynamic_cast<MultiLayer*>(w);
+    auto g3d = dynamic_cast<Graph3D*>(w);
+    if (ml) {
+      QList<Graph *> layers = ml->layersList();
       foreach(Graph *g, layers)
-      g->updateCurveNames(oldName, newName);
-    } else if (w->isA("Graph3D")) {
-      QString name = dynamic_cast<Graph3D*>(w)->formula();
+        g->updateCurveNames(oldName, newName);
+    } else if (g3d) {
+      QString name = g3d->formula();
       if (name.contains(oldName, true)) {
         name.replace(oldName,newName);
-        dynamic_cast<Graph3D*>(w)->setPlotAssociation(name);
+        g3d->setPlotAssociation(name);
       }
     }
   }