Fix logic error introduced by coverity fix.

Refs #11407
mantidproject · Mar 19, 2015 · cbfa325 · cbfa325
1 parent 0998a85
commit cbfa325
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/Code/Mantid/MantidPlot/src/PlotDialog.cpp b/Code/Mantid/MantidPlot/src/PlotDialog.cpp
@@ -1596,15 +1596,14 @@ void PlotDialog::updateTabWindow(QTreeWidgetItem *currentItem, QTreeWidgetItem *
   if (currentItem->type() == CurveTreeItem::PlotCurveTreeItem)
   {
     CurveTreeItem *curveItem = dynamic_cast<CurveTreeItem *>(currentItem);
-    if (!curveItem)
+    if (!curveItem) {
+      boxPlotType->blockSignals(false);
       return;
+    }
 
     CurveTreeItem *pi = dynamic_cast<CurveTreeItem *>(previousItem);
-    if (!pi)
-      return;
-
     if (previousItem->type() != CurveTreeItem::PlotCurveTreeItem
-        || pi->plotItemType() != curveItem->plotItemType()
+        || (pi && pi->plotItemType() != curveItem->plotItemType())
         || forceClearTabs)
     {
       clearTabWidget();