refs #3641 #3876. Fix warnings

mantidproject · Oct 28, 2011 · d8c3d3d · d8c3d3d
1 parent eb5d589
commit d8c3d3d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/Code/Mantid/MantidQt/CustomInterfaces/src/StandardLogView.cpp b/Code/Mantid/MantidQt/CustomInterfaces/src/StandardLogView.cpp
@@ -34,11 +34,12 @@ namespace MantidQt
     /// Initalization method.
     void StandardLogView::initalize(std::vector<AbstractMementoItem_sptr> logs)
     {
-     QTableWidget* tableWidget = new QTableWidget(this);
-     tableWidget->setRowCount(logs.size());
-     tableWidget->setColumnCount(2);
-
-      for(int i = 0; i < logs.size(); i++)
+      int logsSize = int(logs.size());
+      QTableWidget* tableWidget = new QTableWidget(this);
+      tableWidget->setRowCount(logsSize);
+      tableWidget->setColumnCount(2);
+
+      for(int i = 0; i < logsSize; i++)
       {
         std::string value;
         logs[i]->getValue(value);

diff --git a/Code/Mantid/MantidQt/CustomInterfaces/test/AbstractMementoItemTest.h b/Code/Mantid/MantidQt/CustomInterfaces/test/AbstractMementoItemTest.h
@@ -19,7 +19,7 @@ class AbstractMementoItemTest : public CxxTest::TestSuite
       virtual bool hasChanged() const {return false;}
       virtual void commit(){};
       virtual void rollback(){};
-      virtual const std::string& getName() const{return "";};
+      virtual const std::string& getName() const{throw std::runtime_error("Not Implemented");}
       virtual bool equals(AbstractMementoItem&) const {return true;};
       virtual ~DoubleMementoItem() {}
     protected: