Add validation to workspaces to ensure MatrixWorkspaces are used

Refs #11125
mantidproject · Feb 24, 2015 · dac7b69 · dac7b69
1 parent f29d2a0
commit dac7b69
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/Code/Mantid/Framework/Algorithms/src/CopyDetectorMapping.cpp b/Code/Mantid/Framework/Algorithms/src/CopyDetectorMapping.cpp
@@ -42,11 +42,25 @@ void CopyDetectorMapping::exec() {
 std::map<std::string, std::string> CopyDetectorMapping::validateInputs() {
   std::map<std::string, std::string> issues;
 
-  MatrixWorkspace_const_sptr wsToMatch = getProperty("WorkspaceToMatch");
+  MatrixWorkspace_sptr wsToMatch = getProperty("WorkspaceToMatch");
   MatrixWorkspace_sptr wsToRemap = getProperty("WorkspaceToRemap");
 
-  // Check histohram counts match
-  if (wsToMatch->getNumberHistograms() != wsToRemap->getNumberHistograms())
+  // Check that the workspaces actually are MatrixWorkspaces
+  bool validWorkspaces = true;
+
+  if (wsToMatch == NULL) {
+    issues["WorkspaceToMatch"] = "Must be a MatrixWorkspace";
+    validWorkspaces = false;
+  }
+
+  if (wsToRemap == NULL) {
+    issues["WorkspaceToRemap"] = "Must be a MatrixWorkspace";
+    validWorkspaces = false;
+  }
+
+  // Check histohram counts match (assuming both are MatrixWorkspaces)
+  if (validWorkspaces &&
+      wsToMatch->getNumberHistograms() != wsToRemap->getNumberHistograms())
     issues["WorkspaceToRemap"] =
         "Number of histograms must match WorkspaceToMatch";