Refs #4011. Fix some obvious memory leaks picked up by cppcheck.

Code/Mantid/Framework/CurveFitting/src/Convolution.cpp

@@ -83,6 +83,7 @@ void Convolution::functionMW(double* out, const double* xValues, const size_t nD
     API::IFunctionMW* fun = dynamic_cast<API::IFunctionMW*>(getFunction(0));
     if (!fun)
     {
+      delete [] xr;
       throw std::runtime_error("Convolution can work only with IFunctionMW");
     }
     fun->functionMW(m_resolution,xr,nData);
@@ -193,7 +194,7 @@ void Convolution::functionMW(double* out, const double* xValues, const size_t nD
     resolution->functionMW(tmp,xValues,nData);
     std::transform(tmp,tmp+nData,tmp,std::bind2nd(std::multiplies<double>(),dltF));
     std::transform(out,out+nData,tmp,out,std::plus<double>());
-    delete tmp;
+    delete [] tmp;
   }
 
 }

Code/Mantid/Framework/DataHandling/src/SaveISISNexus.cpp

@@ -360,7 +360,7 @@ int SaveISISNexus::saveStringVectorOpen(const char* name,const std::vector<std::
     std::copy(str,str + n,buff);
     NXputslab(handle,buff,start,sizes);
   }
-  delete buff;
+  delete [] buff;
   return buff_size;
 }
 

Code/Mantid/Framework/DataHandling/src/SaveToSNSHistogramNexus.cpp

@@ -33,6 +33,7 @@ In addition, this only works for instruments that use [[RectangularDetector]]s (
 #include <cmath>
 #include <numeric>
 #include <boost/shared_ptr.hpp>
+#include <boost/scoped_array.hpp>
 #include <Poco/File.h>
 //#include <hdf5.h> //This is troublesome on multiple platforms.
 
@@ -584,8 +585,7 @@ namespace DataHandling
               // 1 dimension, with that number of bin boundaries
               dataDimensions[0] = static_cast<int>(X.size());
               // The output TOF axis will be whatever size in the workspace.
-              float *tof_data;                /* pointer to data buffer to write */
-              tof_data = new float[dataDimensions[0]];
+              boost::scoped_array<float> tof_data(new float[dataDimensions[0]]);
 
               // And fill it with the X data
               for (size_t i=0; i < X.size(); i++)
@@ -594,8 +594,7 @@ namespace DataHandling
               if (NXcompmakedata (outId, name, dataType, dataRank, dataDimensions, NX_COMP_LZW, dataDimensions) != NX_OK) return NX_ERROR;
               if (NXopendata (outId, name) != NX_OK) return NX_ERROR;
               if (WriteAttributes (is_definition) != NX_OK) return NX_ERROR;
-              if (NXputdata (outId, tof_data) != NX_OK) return NX_ERROR;
-              delete [] tof_data;
+              if (NXputdata (outId, tof_data.get()) != NX_OK) return NX_ERROR;
               if (NXclosedata (outId) != NX_OK) return NX_ERROR;
 
             }

Code/Mantid/Vates/VatesAPI/src/vtkThresholdingHexahedronFactory.cpp

@@ -281,6 +281,9 @@ namespace VATES
     points->Delete();
     signal->Delete();
     visualDataSet->Squeeze();
+    delete [] pointIDs;
+    delete [] voxelShown;
+    delete [] pointNeeded;
     return visualDataSet;
 
   }

Code/Mantid/Vates/VatesAPI/src/vtkThresholdingQuadFactory.cpp

@@ -197,6 +197,10 @@ namespace Mantid
         points->Delete();
         signal->Delete();
         visualDataSet->Squeeze();
+        delete [] pointIDs;
+        delete [] voxelShown;
+        delete [] pointNeeded;
+
         return visualDataSet;
       }
     }