Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to SetSampleMaterial #10820

Closed
NickDraper opened this issue Jul 23, 2014 · 1 comment
Closed

Improvements to SetSampleMaterial #10820

NickDraper opened this issue Jul 23, 2014 · 1 comment
Assignees
@peterfpeterson
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 3.3

Comments

@NickDraper
Copy link
Contributor

Noted by Spencer:

We have a couple of simple but significant problems in SetSampleMaterial.

  1. SampleNumberDensity and SampleNumberDensityResult input and output in different units (one is per formula and one is per atom). It doesn't matter which we change but they should be the same.
  2. For all Xsections the documentation needs to state the unit is Barns per ?. Currently it appears to be barns per atom, but not stated.
@NickDraper
Copy link
Contributor Author

This issue was originally trac ticket 9978

@NickDraper NickDraper added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@NickDraper NickDraper added this to the Release 3.3 milestone Jun 3, 2015
OwenArnold added a commit that referenced this issue Nov 26, 2015
@OwenArnold
refs #10820. Fix with unit tests in place
3572e2c 
Still need to check axis labelling.
OwenArnold added a commit that referenced this issue Nov 26, 2015
@OwenArnold
refs #10820. Axis labelling introduced and tested.
f20ff02 
I've put in a switch to recover the original behaviour.
OwenArnold added a commit that referenced this issue Nov 26, 2015
@OwenArnold
refs #10820. Fix unitialized warning
8e04a8a
OwenArnold added a commit that referenced this issue Nov 26, 2015
@OwenArnold
refs #10820. Use original dim name
00c5508 
The problem at the moment is that if you execute plotMD, and what should
be the equivalent (ConvertToMatrixWorkspace followed by plotSpectrum), the
x-axis labels are different. plotMD takes the input from the original
workspace, which is better, where as the latter approach is providing
arbitrary labels. If the transform to the original is possible, and the
original workspace has been provided, then that is where the dimension
information is now taken from. Unit tests adapted to show this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterfpeterson peterfpeterson

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.3
Development

No branches or pull requests
2 participants
@peterfpeterson @NickDraper