Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ICAT Search run asynchronously to Refl GUI #14905

Closed
MattKing06 opened this issue Jan 7, 2016 · 1 comment
Closed

Make ICAT Search run asynchronously to Refl GUI #14905

MattKing06 opened this issue Jan 7, 2016 · 1 comment
Assignees
Labels
Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@MattKing06
Copy link
Contributor

This is a sub-issue of #14193

Currently the ICAT search is done through this method. This is currently done is series, however it may be possible to use the AlgorithmRunner and do this asynchronously.

@MattKing06 MattKing06 added the Reflectometry Issues and pull requests related to reflectometry label Jan 7, 2016
@MattKing06 MattKing06 self-assigned this Jan 7, 2016
@MattKing06 MattKing06 added this to the Release 3.6 milestone Jan 7, 2016
@MattKing06
Copy link
Contributor Author

After some investigation into using AlgorithmRunner, I have found that it needs a QObject to be created which would mean adding member variable to QtReflMainView such that this is possible:

//in QtReflMainView.cpp
m_algoRunnner = MantidQt::API::AlgorithmRunner(this)

The ReflMainPresenter can then access m_algoRunner via m_view->m_algoRunner or something to that effect.

However, when it comes to making the ICAT search go through the AlgorithmRunner, it would mean taking the functionality inside ReflCatalogSearcher and putting it inside of the presenter so that the AlgorithmRunner can be used. Other than that the QtReflMainView is not accessible from ReflCatalogSearcher and therefore no AlgorithmRunner can be instantiated there as there is no QObject to be passed into the constructor.

MattKing06 added a commit that referenced this issue Jan 8, 2016
Currently it is working and the search table is populated
but this is just a scratch way of doing things, hopefully
with some review this can be made into a robust solution

Refs #14905
MattKing06 added a commit that referenced this issue Jan 13, 2016
MattKing06 added a commit that referenced this issue Jan 13, 2016
MattKing06 added a commit that referenced this issue Jan 14, 2016
MattKing06 added a commit that referenced this issue Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

1 participant