Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISIS SANS GUI improvements #16863

Closed
AntonPiccardoSelg opened this issue Jul 13, 2016 · 0 comments · Fixed by #16875
Closed

ISIS SANS GUI improvements #16863

AntonPiccardoSelg opened this issue Jul 13, 2016 · 0 comments · Fixed by #16875
Assignees
@AntonPiccardoSelg
Labels
Patch Candidate Urgent issues that must be included in a patch following a release SANS Issues and pull requests related to SANS
Milestone
Release 3.8

Comments

@AntonPiccardoSelg
Copy link
Contributor

Rob has found that some users trip over several issues in the SANS GUI.

They are:

  • reporting service of the Beam Centre Finder seems to be not correct for LARMOR
  • when the hardware fails to provide a BENCH_ROT entry in the sample logs SANS does not warn the users but fails much later. (see run 10351)
  • in batch mode users have speficied outputworkspace names with semi-colons which are then used for the file name to be saved out. This causes a crash of Mantid

Expected solution:

  • Correction of reporting service
  • catch the missing BENCH_ROT when file is being loaded. Note that BENCH_ROT is only expected for new-style SANS runs.
  • convert illegal characters to some default.
@AntonPiccardoSelg AntonPiccardoSelg added the SANS Issues and pull requests related to SANS label Jul 13, 2016
@AntonPiccardoSelg AntonPiccardoSelg added this to the Release 3.8 milestone Jul 13, 2016
@AntonPiccardoSelg AntonPiccardoSelg self-assigned this Jul 13, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 14, 2016
@AntonPiccardoSelg
Refs #16863 Add bench rotation check
c809f58
AntonPiccardoSelg added a commit that referenced this issue Jul 14, 2016
@AntonPiccardoSelg
Refs #16863 Fix bad file name in batch mode
f298f22
AntonPiccardoSelg added a commit that referenced this issue Jul 14, 2016
@AntonPiccardoSelg
Refs #16863 Provide sign to angle calculation for LARMOR
7041e3f
@AntonPiccardoSelg AntonPiccardoSelg mentioned this issue Jul 14, 2016
Merged
9 tasks
AntonPiccardoSelg added a commit that referenced this issue Jul 15, 2016
@AntonPiccardoSelg
Refs #16863 Add better output message
315badb
AntonPiccardoSelg added a commit that referenced this issue Jul 15, 2016
@AntonPiccardoSelg
Refs #16863 Add release notes
645a94c
@AntonPiccardoSelg AntonPiccardoSelg added the Patch Candidate Urgent issues that must be included in a patch following a release label Jul 15, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 19, 2016
@AntonPiccardoSelg
Refs #16863 Fix merge conflict
1825769
AntonPiccardoSelg added a commit that referenced this issue Jul 19, 2016
@AntonPiccardoSelg
Refs #16863 Add testing for missing bench rotation
0fc2f5f
AntonPiccardoSelg added a commit that referenced this issue Jul 19, 2016
@AntonPiccardoSelg
Refs #16863 Add test for quaternion
cc312aa
AntonPiccardoSelg added a commit that referenced this issue Jul 19, 2016
@AntonPiccardoSelg
Refs #16863 Fix pylint issue
68ff4d9
AntonPiccardoSelg added a commit that referenced this issue Jul 20, 2016
@AntonPiccardoSelg
Refs #16863 Fix test
c238211
AntonPiccardoSelg added a commit that referenced this issue Jul 20, 2016
@AntonPiccardoSelg
Refs #16863 More fixes to tests
f57e504
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 Add bench rotation check
025e24b
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 Fix bad file name in batch mode
8932b34
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 Provide sign to angle calculation for LARMOR
bae3c59 
Conflicts:
	scripts/SANS/isis_instrument.py
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 Add better output message
48c3405
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 Add testing for missing bench rotation
3abbb16
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 Add test for quaternion
302ea39 
Conflicts:
	scripts/SANS/isis_instrument.py
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 Fix pylint issue
c64d1e8
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 Fix test
cbb5409
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #16863 More fixes to tests
6e533e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonPiccardoSelg AntonPiccardoSelg

Labels
Patch Candidate Urgent issues that must be included in a patch following a release SANS Issues and pull requests related to SANS
Projects
None yet
Milestone
Release 3.8
Development

Successfully merging a pull request may close this issue.

ISIS SANS improvements to batch processing and beam centre finder mantidproject/mantid
1 participant
@AntonPiccardoSelg