Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASProcessNote not stored correctly by SaveCanSAS1D #16894

Closed
AntonPiccardoSelg opened this issue Jul 15, 2016 · 0 comments
Closed

SASProcessNote not stored correctly by SaveCanSAS1D #16894

AntonPiccardoSelg opened this issue Jul 15, 2016 · 0 comments
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Patch Candidate Urgent issues that must be included in a patch following a release SANS Issues and pull requests related to SANS
Milestone

Comments

@AntonPiccardoSelg
Copy link
Contributor

Steve reported the following:

I’ve discovered that there is a problem with the structure of the CanSAS1D xml file when you include a Processnote.

At present, SaveCanSAS1D is writing this if there is no Processnote:

       <SASprocess>
            <name>Mantid generated CanSAS1D XML</name>
            <date>08-Jul-2016 11:11:10</date>
            <term name="svn">3.6.0</term>
            <term name="user_file">C:/Masks_16_2/USER_SANS2D_162D_2p4_4m_M4_Festa_12mm_SampleChanger.txt</term>
            <SASprocessnote/>
       </SASprocess>
       <SASnote>
       </SASnote>

And this if there is:

       <SASprocess>
            <name>Mantid generated CanSAS1D XML</name>
            <date>15-Jul-2016 14:14:04</date>
            <term name="svn">3.7.1</term>
            <term name="user_file">C:/Masks_16_2/USER_SANS2D_162D_2p4_4m_M4_Festa_12mm_SampleChanger-MaskFlare.txt</term>
            <SASprocessnote/>
       </SASprocess>
       <SASprocess>

Created: E:/Python Bits/M3_42-added_rear.xml - {(1.0 x E:/Python Bits/D2O-Rome-2nd-MT_rear.xml) + (0.57 x E:/Python Bits/H2O-MT_rear.xml)}

       <SASnote>
       </SASnote>

As you can see, a blank line has crept in above SASnote, but also the Processnote is bounded by SASprocess and note SASprocessnote and is in the wrong place. The correct structure should be:

       <SASprocess>
            <name>Mantid generated CanSAS1D XML</name>
            <date>15-Jul-2016 14:14:04</date>
            <term name="svn">3.7.1</term>
            <term name="user_file">C:/Masks_16_2/USER_SANS2D_162D_2p4_4m_M4_Festa_12mm_SampleChanger-MaskFlare.txt</term>
            <SASprocessnote>

Created: E:/Python Bits/M3_42-added_rear.xml - {(1.0 x E:/Python Bits/D2O-Rome-2nd-MT_rear.xml) + (0.57 x E:/Python Bits/H2O-MT_rear.xml)}



This is why the Processnote was not being rendered by the xsl yesterday. And it stops the files being read back in SasView.

@AntonPiccardoSelg AntonPiccardoSelg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) SANS Issues and pull requests related to SANS Framework Issues and pull requests related to components in the Framework labels Jul 15, 2016
@AntonPiccardoSelg AntonPiccardoSelg added this to the Release 3.8 milestone Jul 15, 2016
@AntonPiccardoSelg AntonPiccardoSelg self-assigned this Jul 15, 2016
@AntonPiccardoSelg AntonPiccardoSelg added the Patch Candidate Urgent issues that must be included in a patch following a release label Jul 15, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 18, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 18, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 18, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 19, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 21, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 21, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Patch Candidate Urgent issues that must be included in a patch following a release SANS Issues and pull requests related to SANS
Projects
None yet
Development

No branches or pull requests

1 participant