Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading data without Idev in LoadCanSAS causes Mantid to crash #17002

Closed
AntonPiccardoSelg opened this issue Jul 25, 2016 · 0 comments · Fixed by #17005
Closed

Loading data without Idev in LoadCanSAS causes Mantid to crash #17002

AntonPiccardoSelg opened this issue Jul 25, 2016 · 0 comments · Fixed by #17005
Assignees
@AntonPiccardoSelg
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Patch Candidate Urgent issues that must be included in a patch following a release SANS Issues and pull requests related to SANS
Milestone
Release 3.8

Comments

@AntonPiccardoSelg
Copy link
Contributor

Steve wrote:

Attached are 4 CanSAS 1D files.
cansas-multi – Copy – 2frame.xml and the - 1frame.xml were edited out of a much larger xml file written by SasView with many blocks.
I noted they didn’t have the current v1.1 header (because Lewis called the class directly and the default version is 1.0) so I manually changed it in one file.
writtenby40alpha is a different dataset written by a current build version of SasView. But could just as easily have been written by the current release.
All will read back into SasView and display ok.
writtenby40alpha.xml will load fine into Mantid, but any of the other crash Mantid fatally!

Should not crash since Idev is optional.
@AntonPiccardoSelg AntonPiccardoSelg added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) SANS Issues and pull requests related to SANS Framework Issues and pull requests related to components in the Framework Patch Candidate Urgent issues that must be included in a patch following a release labels Jul 25, 2016
@AntonPiccardoSelg AntonPiccardoSelg added this to the Release 3.8 milestone Jul 25, 2016
@AntonPiccardoSelg AntonPiccardoSelg self-assigned this Jul 25, 2016
AntonPiccardoSelg added a commit that referenced this issue Jul 25, 2016
@AntonPiccardoSelg
Refs #17002 Handle file without Idev
c345cad
AntonPiccardoSelg added a commit that referenced this issue Jul 25, 2016
@AntonPiccardoSelg
Refs #17002 Add unit test
e5dbc80
AntonPiccardoSelg added a commit that referenced this issue Jul 25, 2016
@AntonPiccardoSelg
Refs #17002 Add release notes
162f477
AntonPiccardoSelg added a commit that referenced this issue Jul 25, 2016
@AntonPiccardoSelg
Refs #17002 Add test data
36bdc8f
@AntonPiccardoSelg AntonPiccardoSelg mentioned this issue Jul 25, 2016
Merged
9 tasks
AntonPiccardoSelg added a commit that referenced this issue Jul 25, 2016
@AntonPiccardoSelg
Refs #17002 Correct formatting
5c312a6
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #17002 Handle file without Idev
71f0860
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #17002 Add unit test
1277011
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #17002 Add test data
8311fb1
AntonPiccardoSelg added a commit that referenced this issue Jul 28, 2016
@AntonPiccardoSelg
Refs #17002 Correct formatting
742369e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonPiccardoSelg AntonPiccardoSelg

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Patch Candidate Urgent issues that must be included in a patch following a release SANS Issues and pull requests related to SANS
Projects
None yet
Milestone
Release 3.8
Development

Successfully merging a pull request may close this issue.

load cansas data without idev mantidproject/mantid
1 participant
@AntonPiccardoSelg