Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpecularReflectionPositionCorrect2 crashes with invalid detector name #18905

Closed
gemmaguest opened this issue Feb 17, 2017 · 1 comment · Fixed by #18941
Closed

SpecularReflectionPositionCorrect2 crashes with invalid detector name #18905

gemmaguest opened this issue Feb 17, 2017 · 1 comment · Fixed by #18941
Assignees
@PranavBahuguna
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework Reflectometry Issues and pull requests related to reflectometry
Milestone
Release 3.10

Comments

@gemmaguest
Copy link
Member

Expected behavior

If an invalid DetectorComponentName is provided to SpecularReflectionPositionCorrect2 it should throw an error.

Actual behavior

Segmentation fault.

Steps to reproduce the behavior

The following script demonstrates the problem:

inter = Load(Filename='INTER13460')
inter_new = SpecularReflectionPositionCorrect(inter, TwoTheta = 2*0.49, DetectorComponentName='lineardetector')

Platforms affected

Probably all (confirmed on Windows & Ubuntu)
@gemmaguest gemmaguest added Framework Issues and pull requests related to components in the Framework Reflectometry Issues and pull requests related to reflectometry Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels Feb 17, 2017
@gemmaguest gemmaguest added this to the Release 3.10 milestone Feb 17, 2017
@gemmaguest gemmaguest mentioned this issue Feb 17, 2017
Merged
9 tasks
PranavBahuguna added a commit that referenced this issue Feb 21, 2017
@PranavBahuguna
Re #18905 Added input validation for detector + sample names
ee24d82
PranavBahuguna added a commit that referenced this issue Feb 21, 2017
@PranavBahuguna
Re #18905 Added relevant unit tests
ca55588
@PranavBahuguna
Copy link
Contributor

A similar bug occurs if an invalid sample component name is given. I have fixed this too.

PranavBahuguna added a commit that referenced this issue Feb 21, 2017
@PranavBahuguna
Re #18905 Updated release notes
8d90400
@PranavBahuguna PranavBahuguna mentioned this issue Feb 21, 2017
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PranavBahuguna PranavBahuguna

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.10
2 participants
@PranavBahuguna @gemmaguest