Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartLiveData sometimes ignores Listener Properties #20489

Closed
MikeHart85 opened this issue Sep 15, 2017 · 0 comments
Closed

StartLiveData sometimes ignores Listener Properties #20489

MikeHart85 opened this issue Sep 15, 2017 · 0 comments
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing)
Milestone

Comments

@MikeHart85
Copy link
Contributor

MikeHart85 commented Sep 15, 2017

PR #17926 makes it possible to pass Listener Properties as arguments when calling StartLiveData from Python.

However, under some circumstances, those arguments may be ignored and the properties are treated as if they have their default values. This only affect properties "pulled in" from the specific Listener being used, not properties that are part of StartLiveData itself.

This happens because Listener Properties are reset / reloaded whenever the Instrument, Listener or Connection property of StartLiveData changes. Instrument is treated as a special case, so that never causes this problem. But if Listener or Connection has been passed in as an argument, it's down to luck / Python dict order whether Listener Properties are reset before (OK) or after they are set (which destroys the value).

@MikeHart85 MikeHart85 added Component: Live Data Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels Sep 15, 2017
@MikeHart85 MikeHart85 added this to the Release 3.11 milestone Sep 15, 2017
@MikeHart85 MikeHart85 self-assigned this Sep 15, 2017
MikeHart85 pushed a commit that referenced this issue Oct 4, 2017
peterfpeterson added a commit that referenced this issue Oct 4, 2017
…erties_fix

Re #20489 More reliable argument handling in StartLiveData
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing)
Projects
None yet
Development

No branches or pull requests

2 participants