Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move C++ Python utility code out of kernel to PythonInterfaceCore libary #26334

Closed
martyngigg opened this issue Jul 15, 2019 · 0 comments · Fixed by #26362
Closed

Move C++ Python utility code out of kernel to PythonInterfaceCore libary #26334

martyngigg opened this issue Jul 15, 2019 · 0 comments · Fixed by #26362
Assignees
@dtasev
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Maintenance

Comments

@martyngigg
Copy link
Member

The _kernel library should be purely the exports required for the module. All utility types and functions should be moved to PythonInterfaceCore
@martyngigg martyngigg created this issue from a note in Maintenance (To do) Jul 15, 2019
@martyngigg martyngigg added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Jul 15, 2019
@martyngigg martyngigg mentioned this issue Jul 15, 2019
Closed
dtasev pushed a commit that referenced this issue Jul 16, 2019
Moves Cpp Python utility code into PythonInterfaceCore, Re #26334
1f6f2d9
@dtasev dtasev mentioned this issue Jul 16, 2019
Merged
dtasev pushed a commit that referenced this issue Jul 16, 2019
Moves Cpp Python utility code into PythonInterfaceCore, Re #26334
d056d42
@dtasev dtasev moved this from To do to In progress in Maintenance Jul 17, 2019
@dtasev dtasev self-assigned this Jul 17, 2019
dtasev pushed a commit that referenced this issue Jul 17, 2019
Moves Cpp Python utility code into PythonInterfaceCore, Re #26334
9d12050
dtasev pushed a commit that referenced this issue Jul 17, 2019
Remove duplicated extern template declaration re #26334
8ea062a
dtasev pushed a commit that referenced this issue Jul 17, 2019
Link PythonInterfaceCore to Kernel for Matrix and VMD, re #26334
c00cb7c
dtasev pushed a commit that referenced this issue Jul 23, 2019
Add back extern template declarations into WrapWithNDArray, re #26334
5561a7c
dtasev pushed a commit that referenced this issue Jul 24, 2019
Moves Cpp Python utility code into PythonInterfaceCore, Re #26334
4ce4469
dtasev pushed a commit that referenced this issue Jul 24, 2019
Remove duplicated extern template declaration re #26334
fcf1493
dtasev pushed a commit that referenced this issue Jul 24, 2019
Link PythonInterfaceCore to Kernel for Matrix and VMD, re #26334
57f7c24
dtasev pushed a commit that referenced this issue Jul 24, 2019
Add back extern template declarations into WrapWithNDArray, re #26334
4938f75
dtasev pushed a commit that referenced this issue Jul 25, 2019
Move ComponentInfo and DetectorInfo PythonIterators to geometry
007efe3 
Re #26334
dtasev pushed a commit that referenced this issue Jul 31, 2019
Specify correct doxygen dirs for kernel/api includes, re #26334
138c580
Maintenance automation moved this from In progress to Done Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtasev dtasev

Labels
Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Mantid Maintenance
Status: Done
Maintenance
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moves C++ Python utility code into PythonInterfaceCore mantidproject/mantid
2 participants
@martyngigg @dtasev