Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit broken on Windows #36554

Closed
thomashampson opened this issue Dec 13, 2023 · 0 comments · Fixed by #36562
Closed

pre-commit broken on Windows #36554

thomashampson opened this issue Dec 13, 2023 · 0 comments · Fixed by #36562
Assignees
@jclarkeSTFC
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Windows Only Only on Windows
Milestone
Release 6.9

Comments

@thomashampson
Copy link
Contributor

thomashampson commented Dec 13, 2023 •
edited

Describe the bug
Since this pre-commit update, running cmake on Windows will break pre-commit.

To Reproduce
e.g. build in Visual Studio and then try to commit something.

Expected behavior
should work

Platform/Version (please complete the following information):

  • OS: Windows

Additional context
The pre-commit file that is copied to a python file is not longer python, so the logic generated by cmake doesn't work any more. We might be able to remove this step now (see here).
@thomashampson thomashampson added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Windows Only Only on Windows labels Dec 13, 2023
@thomashampson thomashampson added this to the Release 6.9 milestone Dec 13, 2023
@thomashampson thomashampson added the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label Dec 13, 2023
@jclarkeSTFC jclarkeSTFC self-assigned this Dec 14, 2023
@jclarkeSTFC jclarkeSTFC mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jclarkeSTFC jclarkeSTFC

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Windows Only Only on Windows
Projects
No open projects
Release 6.9 ISIS Core
Status: Done
Milestone
Release 6.9
Development

Successfully merging a pull request may close this issue.

Remove cmake code that breaks pre-commit on Windows mantidproject/mantid
2 participants
@thomashampson @jclarkeSTFC