Remove cmake code that breaks pre-commit on Windows #36562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code copied the contents of ``.git/hooks/pre-commit`` to a new file called ``pre-commit-script.py``, then changed ``pre-commit`` to run ``pre-commit-script.py`` with python. But now the contents of ``pre-commit`` is bash, not python, so don't do any of this copying any more.
jclarkeSTFC
added
High Priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code deleted here copied the contents of
.git/hooks/pre-committo a new file calledpre-commit-script.py, then changedpre-committo runpre-commit-script.pywith python. But now the contents ofpre-commitis bash, not python, so don't do any of this copying any more.Fixes #36554.
To test:
Best to make sure your environment is up to date. On Windows you need to run
cmaketo make sure your files in.git/hooks/are updated to the broken version. You should then be able to commit with no problems.This does not require release notes because it's not relevant to the user.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.