Change Corelli bank names to sequentially numbered banks. i.e. bank1,.. #13026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VickieLynch
added a commit
that referenced
this pull request
Jul 7, 2015
Change Corelli bank names to sequentially numbered banks. i.e. bank1,..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the banks being named A1, A2, A3... B1, B2, B3... they will now all be sequential bank1, bank2, ..., bank91
Generated by https://github.com/mantidproject/mantidgeometry/blob/master/corelli_geometry.py
This is done at the request of the Corelli instrument scientists to make the bank names the same as in the NeXus file.
To test
And see if the banks are correctly named.
Since the IDF is included in the NeXus file itself this only included here for the few Algorithms that need it.
Release notes not needed.