Algorithm to calibrate detector phases #13840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muon scientists may be used to the old property name, so I've decided to keep it
Chatted with James this morning and this information is necessary
Not sure if this caused the last build to fail on all platforms but windows
…ectorPhases_algorithm
…alMuonDetectorPhases_algorithm
raquelalvarezbanos
added
Muon
| multi->setDomainIndex(i, i); | ||
| } | ||
|
|
||
| API::IAlgorithm_sptr fit = createChildAlgorithm("Fit"); |
There was a problem hiding this comment.
Just as a comment, something that I also usually neglect: in places like here you could use auto.
|
All looks good, the algorithm works well and even users not familiar with this area can understand the documentation. |
FedeMPouzols
added a commit
that referenced
this pull request
Oct 5, 2015
…rPhases_algorithm Algorithm to calibrate detector phases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11868
This must be merged after PRs #13830 and #13686 are merged.
For tester: have a look at the documentation for a description of the algorithm and a user example. I would say that code review should be enough as the algorithm will be tested by scientists. In addition, you may want to run the algorithm on a real muon dataset. If so, I would recommend fitting a subset of spectra as the Fit algorithm may be a bit slow.