Fix poco 1.6.0 warnings #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oddly enough the last build failed on a couple of platforms because of the git-checkout issue again. The same checkout command worked well on the other platforms. |
|
Well the changes are obviously fine but just to make sure I'm going to try with a 'retest this please'. Not sure if it will work when I write it... |
|
retest this please |
1 similar comment
|
retest this please |
|
Thanks Harry for re-starting the build. For some reason the bug in the Jenkins plugin really likes this pull request. It failed again on 3 platforms! |
|
retest this please |
|
All looks good and the builds went through at last. |
FedeMPouzols
added a commit
that referenced
this pull request
Feb 10, 2015
…p0_warnings Fix poco 1.6.0 warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Poco/Platform_POSIX.h and Code/Mantid/Framework/Kernel/inc/MantidKernel/WarningSuppressions.h define the macros GCC_DIAG_ON(x) and GCC_DIAG_OFF(x). The compiler warnings can be suppressed by undefining both macros before they are defined in WarningSuppressions.h.
testing: review changes and check tests. Testing on a machine with poco 1.6.0 installed is not necessary.
http://trac.mantidproject.org/mantid/ticket/10977