Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workspaces produced by GetNegMuMuonicXRD plottable #14484

Merged
merged 1 commit into from Nov 18, 2015

Conversation

MattKing06
Copy link
Contributor

The x-values featured in the dictionary for the GetNegMuMuonicXRD algorithm needed to be sorted in ascending order so that they could be plotted.

To Test:

  • Load GetNegMuMuonicXRD
  • Choose any element
  • select a value for Y-shift
  • enter a name for the output workspace
  • Run the algorithm
  • Right click -> Plot Spectrum for each workspace in the output group workspace
  • See that they actually plot

Release Notes: //todo

Fixes #14347

@MattKing06 MattKing06 added the Muon Issues and pull requests related to muons label Nov 18, 2015
@MattKing06 MattKing06 added this to the Release 3.6 milestone Nov 18, 2015
@ElliotAOram ElliotAOram self-assigned this Nov 18, 2015
@ElliotAOram
Copy link
Contributor

This works as described. I'm happy to merge once is passes the build servers
@MattKing06 Two things for possible future development (Not sure if this is appropriate - please ignore if not!)

  1. It would be nice to see something in the Sample Log. Currently it only contains run_title.
  2. Secondly it might be worth populating the Sample Material with at the least the Formula
    These could be separate issues as they are unrelated to this issue

@MattKing06
Copy link
Contributor Author

@ElliotAOram I think you're right, I will discuss was could be contained in the sample logs with Adrian when I next see him. Thanks! 👍

ElliotAOram pushed a commit that referenced this pull request Nov 18, 2015
…egMuMuonicXRD

Make workspaces produced by GetNegMuMuonicXRD plottable
@ElliotAOram ElliotAOram merged commit e16ac1a into master Nov 18, 2015
@ElliotAOram ElliotAOram deleted the 14347_fix_plots_for_getNegMuMuonicXRD branch November 18, 2015 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Muon Issues and pull requests related to muons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants