Fix sequential fits in Muon Analysis interface #14807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If "ApplyDeadTimeCorrection" is set but there is no dead time table set on the algorithm passed in, we need to load the dead times from the file. - The output workspace type has been corrected. - In the catch, write the exception's error message to the log.
|
Once I've loaded the file, I go to the Data Analysis tab to select |
|
Did you add a function to the fit? The 'Fit' and 'Sequential fit' options should both be enabled if the composite function has at least 1 function in it. (Were they both disabled or just the sequential one?) |
|
Ahh I see, I've got it working now, thanks 👍 |
MattKing06
added a commit
that referenced
this pull request
Dec 17, 2015
…nAnalysis Works well when no Dead Time table is supplied with a good error message telling the user exactly what was wrong. Happy to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14800
Sequential fits in the Muon Analysis interface were failing. The sequential fit dialog is passed a MuonProcess algorithm with some properties set, and loads each file and passes it through this algorithm.
If the algorithm passed in has the property "ApplyDeadTimeCorrection" set true, it will expect there to be a dead time table. If this is not the case then the processing fails. This PR checks this property and, if no dead time table is set, loads the dead times from the file.
Other changes:
To test
\\olympic\babylon5\Public\TomPerkins(emu00059683-5.nxs) and put them in a directory where Mantid can find them59683-59685in the Runs box and start the fit.