Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALC interface: fit progress and Plot Guess option #14842

Merged
merged 5 commits into from Jan 4, 2016
Merged

ALC interface: fit progress and Plot Guess option #14842

merged 5 commits into from Jan 4, 2016

Conversation

tom-perkins
Copy link

Resolves #14840

  • Changed the fit algorithms in the baseline modelling and peak fitting stages to run asynchronously. This means that their progress will be shown in the MantidPlot UI.
  • Added a "Plot guess" button to the peak fitting UI, which works like "Plot guess" elsewhere. The alternative would be to replace the pane here with a FitPropertyBrowser as in Muon Analysis.
  • Updated the release notes
  • Added unit tests

To test:

  • Start the ALC interface (Interfaces/Muon/ALC) and load start/end data files. A minimal data set is MUSR00015189-15193 (in the doctest data), or a more extensive example with peaks to fit is HIFI00051636-51786 (\\hifi\data\cycle_13_1).
  • Go to the next screen and fit a baseline to the data. It's hard to see the progress bar appear here as it is so fast, but try clicking "Fit" several times and see if you can see it appear.
  • Go to the peak fitting screen and add one or more peaks. Check that the "Plot guess" button plots a guess fit, and that it works as it should with the fit.
  • Run the fit and check that the progress is shown in MantidPlot. (The progress bar may only appear fleetingly if the fit is fast). If the fit is lengthy enough, check that the UI doesn't freeze while it is ongoing.

Tom Perkins added 3 commits December 22, 2015 13:37
Re #14840 Show fitting progress in ALC interface
fb5a8cc 
The Muon ALC interface's fit did not show a progress bar, so run the fit
algorithm asynchronously so that progress is shown. The busy wait is
necessary so that the GUI doesn't freeze in the meantime - this seems to
be the standard way of doing this in the codebase at present.
Re #14840 Show fit progress on baseline modelling step too
8008123
Re #14840 ALC: add a "Plot guess" button for peak fitting page
a3c59b3 
Button changes its text depending on whether a guess or a fit is plotted.
@tom-perkins tom-perkins added State: In Progress Muon Issues and pull requests related to muons labels Dec 22, 2015
@tom-perkins tom-perkins added this to the Release 3.6 milestone Dec 22, 2015
@LamarMoore LamarMoore self-assigned this Jan 4, 2016
@LamarMoore
Copy link
Contributor

Looks good to me. I am happy to merge

LamarMoore added a commit that referenced this pull request Jan 4, 2016
@LamarMoore
Merge pull request #14842 from mantidproject/14840_ALC_fitting_progress
6112d8a 
ALC interface: fit progress and Plot Guess option
@LamarMoore LamarMoore merged commit 6112d8a into master Jan 4, 2016
@LamarMoore LamarMoore deleted the 14840_ALC_fitting_progress branch January 4, 2016 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LamarMoore LamarMoore

Labels
Muon Issues and pull requests related to muons
Projects
None yet
Milestone
Release 3.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tom-perkins @LamarMoore