Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed 'Cancel' button behaviour in "Open Table" messageBox for Reflectometry GUI #15083

Merged
merged 3 commits into from Jan 25, 2016
Merged

Fixed 'Cancel' button behaviour in "Open Table" messageBox for Reflectometry GUI #15083

merged 3 commits into from Jan 25, 2016

Conversation

MattKing06
Copy link
Contributor

_This was found during unscripted testing for Reflectometry_

To Test:

  • Download SampleData-ISIS so that INTER_NR_test.tbl is in your managed data directories
  • Open up the Reflectometry Interface Interfaces > Reflectometry > ISIS Reflectometry
  • Open the .tbl file (File > Open Table..)
  • Edit some values in the table
  • Open another .tbl file (File > Open Table..)
  • Make sure a dialog pops up asking you about discarding your files
  • Click Cancel
  • Make sure the values you entered previously are still present and the table hasn't been reset.

Release Notes:
http://www.mantidproject.org/Release_Notes_3_6_Reflectometry#ISIS_Reflectometry_.28Polref.29

Fixes #15046

@MattKing06 MattKing06 added Reflectometry Issues and pull requests related to reflectometry Component: GUI labels Jan 25, 2016
@MattKing06 MattKing06 added this to the Release 3.6 milestone Jan 25, 2016
@ElliotAOram ElliotAOram self-assigned this Jan 25, 2016
@ElliotAOram
Copy link
Contributor

Works exactly as described above. Happy to merge once tests pass and Release notes are written!

ElliotAOram pushed a commit that referenced this pull request Jan 25, 2016
Merge pull request #15083 from mantidproject/15046_fix_open_table_in_…
71bc5ea 
…reflectometry_interface

Fixed 'Cancel' button behaviour in "Open Table" messageBox for Reflectometry GUI
@ElliotAOram ElliotAOram merged commit 71bc5ea into master Jan 25, 2016
@ElliotAOram ElliotAOram deleted the 15046_fix_open_table_in_reflectometry_interface branch January 25, 2016 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ElliotAOram ElliotAOram

Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MattKing06 @ElliotAOram