Move the source back to its original position #15139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquelalvarezbanos
added
High Priority
|
@shahrozahmed1 You will have to merge this manually to |
|
|
shahrozahmed1
pushed a commit
that referenced
this pull request
Feb 3, 2016
…ck_to_original_position Move the source back to its original position
shahrozahmed1
deleted the
15136_Move_the_source_back_to_original_position
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15136
Tester:
See #15136 for a description of the problem and run the example script. With this fix, you should get the following
QxQzmapI still don't understand why we need to have the source in the "correct" position (i.e. at
(0, y, -z)) forConvertUnits, but we have to have it at(0, 0, -z)forConvertSpectrumAxis.