Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added if section for google analytics in online help. #155

Merged
merged 1 commit into from Feb 2, 2015

Conversation

NickDraper
Copy link
Contributor

This was originally #10992

To test:

  1. Build docs-html and docs-qthelp.
  2. Look at any html file in the results and see that the online help has the javascript and that the offline doesn't.

@mantid-builder
Copy link
Collaborator

Can one of the admins verify this patch?

@peterfpeterson
Copy link
Member

test this please

@peterfpeterson
Copy link
Member

retest this please

@peterfpeterson
Copy link
Member

The ubuntu builder was unable to checkout the code. That error can be ignored and the pull request merged.

martyngigg added a commit that referenced this pull request Feb 2, 2015
Added if section for google analytics in online help.
@martyngigg martyngigg merged commit 5b4d9e8 into master Feb 2, 2015
@martyngigg martyngigg deleted the 10992_google_analytics branch February 2, 2015 20:56
@martyngigg
Copy link
Member

Checked the files locally and the section appears in the HTML but not Qt help as expected.

@peterfpeterson peterfpeterson added the Documentation Issues and pull requests related to documentation label Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants