Update sans.rst #18511
Merged
Update sans.rst #18511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just added a few fullstops and changed a few words
AnthonyLim23
added
the
Documentation
|
@AnthonyLim23 |
|
yes you are right, I will change that. I just put fixed to be consistent |
changed to fix for beam ...
|
@AnthonyLim23 When you make a change and push it, it is recommended to cancel the builds on previous commits. This can free up considerable resources. Thanks |
|
I am not sure how to do that from github. I do not have access to anything else from home. |
|
notes look fine. Once tests pass, please |
| - Fix wrong initial position of LARMOR data in the beam centre finder | ||
| - Allow loading of CanSAS data without error data | ||
| - Fix saving CanSAS with transmission data from the ISIS SANS GUI | ||
| - Fix for beam center finder. |
There was a problem hiding this comment.
Fixed instead of Fix? Just to be consistent
There was a problem hiding this comment.
Sorry, I did not carefully read the previous comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added a few fullstops and changed a few words
Description of work.
To test:
Fixes #xxxx.
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Do changes function as described? Add comments below that describe the tests performed?
How do the changes handle unexpected situations, e.g. bad input?
Has the relevant documentation been added/updated?
Is user-facing documentation written in a user-friendly manner?
Has developer documentation been updated if required?
Does everything look good? Comment with the ship it emoji but don't merge. A member of
@mantidproject/gatekeeperswill take care of it.