Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source position and name for IN4 spectrometer #18681

Merged
merged 1 commit into from Feb 6, 2017

Conversation

soininen
Copy link

@soininen soininen commented Feb 2, 2017

This PR moves the source of the IN4 spectrometer at ILL from the rather arbitrary z = -2m to the position of the Fermi chopper at z = -0.675.

To test:

Check that the L1 distance for IN4 is 0.675 meters instead of the earlier 2m.

Fixes #18679.

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@soininen soininen added this to the Release 3.10 milestone Feb 2, 2017
@KarlPalmen KarlPalmen self-assigned this Feb 3, 2017
@KarlPalmen
Copy link
Contributor

Source has been moved to Fermi-chopper at 0.675 and moderator (the old source) has been removed and there are no references to it in the IDF file.

@KarlPalmen
Copy link
Contributor

KarlPalmen commented Feb 3, 2017

Instrument IN4 loaded with out error and then displayed OK without error.

@KarlPalmen
Copy link
Contributor

:shipit: subject to builds working.

@KarlPalmen KarlPalmen removed their assignment Feb 3, 2017
@martyngigg martyngigg merged commit c63ff62 into master Feb 6, 2017
@martyngigg martyngigg deleted the 18679_IN4_move_source branch February 6, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants