Skip to content

Fix zeropadding for IMAT in Facilities.XML#18907

Merged
martyngigg merged 1 commit into
masterfrom
fix_facilities_padding_imat
Feb 20, 2017
Merged

Fix zeropadding for IMAT in Facilities.XML#18907
martyngigg merged 1 commit into
masterfrom
fix_facilities_padding_imat

Conversation

@dtasev
Copy link
Copy Markdown
Contributor

@dtasev dtasev commented Feb 17, 2017

A quick change that fixes being able to load IMAT workspaces through the data archive.

No related issue.

@dtasev dtasev added this to the Release 3.10 milestone Feb 17, 2017
@DavidFair DavidFair added Framework Issues and pull requests related to components in the Framework Misc: Easy labels Feb 17, 2017
@DavidFair
Copy link
Copy Markdown
Contributor

Tested locally and it now correctly picks up IMAT filenames :shipit:

@martyngigg martyngigg self-assigned this Feb 20, 2017
@martyngigg
Copy link
Copy Markdown
Member

@DavidFair Have their filenames always been padded to 8 digits or is it a recent change?

@martyngigg
Copy link
Copy Markdown
Member

I've just checked the runs in cycle 15_1 and they are all padded to 8 digits.

@martyngigg martyngigg added the Patch Candidate Urgent issues that must be included in a patch following a release label Feb 20, 2017
@martyngigg martyngigg merged commit 97f8d62 into master Feb 20, 2017
@martyngigg martyngigg deleted the fix_facilities_padding_imat branch February 20, 2017 12:19
@DavidFair
Copy link
Copy Markdown
Contributor

Sorry - yes they have always had 8 digits as it is a (relatively) new instrument.

martyngigg added a commit that referenced this pull request Feb 23, 2017
added zeropadding in facilities xml

(cherry picked from commit e119e47)

and modify patch release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues and pull requests related to components in the Framework Patch Candidate Urgent issues that must be included in a patch following a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants