Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SNSPowderReduction work with various splitter workspaces #19194

Merged
merged 10 commits into from Mar 29, 2017

Conversation

wdzhou
Copy link
Collaborator

@wdzhou wdzhou commented Mar 20, 2017

Make SNSPowderReduction work with various types of workspaces that contain splitters.

To test:

a1. create 1 splitters workspaces by GenerateEventsFilter. Set 'FastLog' to True. The splitter workspace should be a MatrixWorkspace
a2. run SNSPowderReduction with this MatrixWorkspace splitters.

b1. create a 3 column TableWorkspace. column 0 and 1 should be float, and column should be string. Column 0 should be the start time of a splitter; column 1 be the stop time; and column 3 be the target workspace tag.
b2. run SNSPowderReduction with this TableWorkspace.

Fixes #19139.

New feature is reported in the release note.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@wdzhou wdzhou added Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction State: In Progress labels Mar 20, 2017
@wdzhou wdzhou added this to the Release 3.10 milestone Mar 20, 2017
@peterfpeterson
Copy link
Member

I tried out the PD interface and the system tests that aren't usually run. Everything works. :shipit:

@AndreiSavici AndreiSavici merged commit c0bd739 into master Mar 29, 2017
@AndreiSavici AndreiSavici deleted the 19139_snspdr_new_splitters branch March 29, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants