Make SNSPowderReduction work with various splitter workspaces #19194

merged 10 commits into from Mar 29, 2017


None yet
3 participants

wdzhou commented Mar 20, 2017

Make SNSPowderReduction work with various types of workspaces that contain splitters.

To test:

a1. create 1 splitters workspaces by GenerateEventsFilter. Set 'FastLog' to True. The splitter workspace should be a MatrixWorkspace
a2. run SNSPowderReduction with this MatrixWorkspace splitters.

b1. create a 3 column TableWorkspace. column 0 and 1 should be float, and column should be string. Column 0 should be the start time of a splitter; column 1 be the stop time; and column 3 be the target workspace tag.
b2. run SNSPowderReduction with this TableWorkspace.

Fixes #19139.

New feature is reported in the release note.


Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.


This comment has been minimized.

Show comment
Hide comment

peterfpeterson Mar 29, 2017


I tried out the PD interface and the system tests that aren't usually run. Everything works. :shipit:


peterfpeterson commented Mar 29, 2017

I tried out the PD interface and the system tests that aren't usually run. Everything works. :shipit:

@AndreiSavici AndreiSavici merged commit c0bd739 into master Mar 29, 2017

9 checks passed

ClangFormat Jenkins build pull_requests-clang-format 12238 has succeeded
Doxygen Jenkins build pull_requests-doxygen 11650 has succeeded
Flake8 Jenkins build pull_requests-flake8 2951 has succeeded
OSX Jenkins build pull_requests-osx 12797 has succeeded
RHEL7 + System Tests Jenkins build pull_requests-rhel7 12702 has succeeded
Ubuntu + Doc Tests Jenkins build pull_requests-ubuntu 13301 has succeeded
Ubuntu Python 3 Jenkins build pull_requests-ubuntu-python3 860 has succeeded
Windows Jenkins build pull_requests-win7 13571 has succeeded
cppcheck Jenkins build pull_requests-cppcheck 13246 has succeeded

@AndreiSavici AndreiSavici deleted the 19139_snspdr_new_splitters branch Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment