Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write PeakShape #196

Merged
merged 14 commits into from Feb 10, 2015
Merged

Write PeakShape #196

merged 14 commits into from Feb 10, 2015

Conversation

OwenArnold
Copy link
Contributor

see #10904

@OwenArnold
refs #10904. IntegratePeaksMD algorithms done.
4427109 
IntegratePeaksMD v1 and v2 write out integrated peak info in the form of PeakShape

PeakShapeSpherical adapted to write out background outer radius and background inner radius as well as the peak radius. Factories also updated for this, unit tests added to and updated for this.

I got a little worried that someone may change the integer values agaist the enum entries of SpecialCoordinateSystem. So I put in place a unit test to sanity check those.
@OwenArnold
refs #10904. Ellipsoid shape.
2387ce5
@OwenArnold
refs #10904. Factory for elliptical peak shapes
78da658
@OwenArnold
refs #10904. Hook new factory into loader.
8d327c5
@OwenArnold
refs #10904. Write from IntegrateEllipsoids.
3d558b3
@OwenArnold
refs #10904. Mv PeakShape an fix warnings.
0dd26e0
@OwenArnold
refs #10904. Fix remaining warning.
43d4e25
@OwenArnold
refs #10904. Expose PeakShape to python.
bf27026
@OwenArnold
refs #10904 SpecialCoords API->Kernel
5612143 
Since we have put PeakShape in Geometry, SpecialCoordinateSystem must be moved to the Kernel package out of API.
@OwenArnold
refs #10904. Python tests for PeakShape.
8996ec6 
Also fix GCC and Windows warnings
@OwenArnold
refs #10904. Resolve conflict with master.
f910af2
@OwenArnold
refs #10904. Fix windows build.
a22ac8e
@OwenArnold
refs #10904. Fix bad include.
53d30cb
@OwenArnold
refs #10904. Scope resolution for enum
df4c56a
@martyngigg martyngigg added this to the Release 3.4 milestone Feb 10, 2015
@martyngigg martyngigg self-assigned this Feb 10, 2015
@martyngigg martyngigg added Single Crystal Issues and pull requests related to single crystal Vates labels Feb 10, 2015
@martyngigg
Copy link
Member

The script from the ticket works as expected and so do all of the methods on the new PeakShape class. I can see that most of the changes are due to the move of the SpecialCoordinateSystem.

martyngigg added a commit that referenced this pull request Feb 10, 2015
@martyngigg
Merge pull request #196 from mantidproject/feature/10904_apply_peak_s…
35142ef 
…hape
@martyngigg martyngigg merged commit 35142ef into master Feb 10, 2015
@martyngigg martyngigg deleted the feature/10904_apply_peak_shape branch February 10, 2015 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martyngigg martyngigg

Labels
Single Crystal Issues and pull requests related to single crystal Vates
Projects
None yet
Milestone
Release 3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OwenArnold @martyngigg