Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slit calculator #197

Merged
merged 9 commits into from Feb 16, 2015
Merged

Add slit calculator #197

merged 9 commits into from Feb 16, 2015

Conversation

eXeC64
Copy link
Contributor

@eXeC64 eXeC64 commented Feb 10, 2015

This is ticket #10828

In this pull request we:

  • Add the CalculateSlits algorithm.
    • Documentation also added
    • Unit test also added
  • Add a SlitCalculator widget.
  • Add a menu item for the slit calculator in both the new and old ISIS Reflectometry Reduction UIs.
  • Fixed some indentation errors in MantidWidgets' CMakeLists.txt

@eXeC64 eXeC64 added Reflectometry Issues and pull requests related to reflectometry MantidPlot and removed MantidPlot labels Feb 10, 2015
@eXeC64 eXeC64 added this to the Release 3.4 milestone Feb 10, 2015
@OwenArnold OwenArnold assigned OwenArnold and unassigned JeanBilheux Feb 13, 2015
@OwenArnold
Copy link
Contributor

If it's OK with you Jean, I'd like to verify this one.

@JeanBilheux
Copy link
Contributor

no problem. And you are more the guy to do it anyway.

Jean

On Feb 13, 2015, at 12:07 PM, Owen Arnold <notifications@github.commailto:notifications@github.com> wrote:

If it's OK with you Jean, I'd like to verify this one.

�
Reply to this email directly or view it on GitHubhttps://github.com//pull/197#issuecomment-74288210.

@OwenArnold
Copy link
Contributor

All looks working as expected. Please add a section about the slit calculator here http://www.mantidproject.org/ISIS_Reflectometry_GUI.

@OwenArnold OwenArnold closed this Feb 15, 2015
@eXeC64 eXeC64 reopened this Feb 16, 2015
OwenArnold added a commit that referenced this pull request Feb 16, 2015
@OwenArnold
Merge pull request #197 from mantidproject/feature/10828_slits_calcul…
5d9e8cd 
…ator

Add slit calculator
@OwenArnold OwenArnold merged commit 5d9e8cd into master Feb 16, 2015
@OwenArnold OwenArnold deleted the feature/10828_slits_calculator branch February 16, 2015 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@OwenArnold OwenArnold

Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eXeC64 @OwenArnold @JeanBilheux