Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in PoldiPeakSearchTest under Windows debug #208

Merged
merged 1 commit into from Feb 15, 2015

Conversation

MichaelWedel
Copy link
Contributor

Fixes trac issue #11065

The MSVC debugger is giving an out of bounds error for the PoldiPeakSearch::getFWHMEstimate. The debugger says that during the testGetPeakCoordinates method the nextIntensity iterator goes past the end of the vector.

@MichaelWedel
Copy link
Contributor Author

Testing information
The branch has been merged into develop. Please make sure that PoldiPeakSearchTest is passing in the debug-build.

@martyngigg martyngigg added this to the Release 3.4 milestone Feb 12, 2015
@martyngigg martyngigg added the Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) label Feb 12, 2015
@martyngigg martyngigg self-assigned this Feb 12, 2015
@martyngigg
Copy link
Member

This looks fine now.

martyngigg added a commit that referenced this pull request Feb 15, 2015
…h_array_bounds

Failure in PoldiPeakSearchTest under Windows debug
@martyngigg martyngigg merged commit 07967d0 into master Feb 15, 2015
@martyngigg martyngigg deleted the 11065_fix_poldi_peak_search_array_bounds branch February 15, 2015 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants